🤖 fix: enable queued messages during compaction #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove isCompacting check from textarea disabled condition - Remove isCompacting check from handleSend early return - Update placeholder to show queuing capability during compaction Users can now type and queue messages while compaction is running. Messages are automatically queued by backend and sent after compaction completes. _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Messages could not be queued during compaction because the text input was disabled when
isCompactingwas true. The backend was already ready to queue messages during any streaming operation (including compaction), but the frontend blocked users from typing.Solution
isCompactingcheck from textarea disabled conditionisCompactingcheck fromhandleSendearly returnTesting
Generated with
mux